Fix unicode character uri bug #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmholt
approved these changes
Jan 6, 2020
src/PowerShellEditorServices/Services/Workspace/WorkspaceService.cs
Outdated
Show resolved
Hide resolved
src/PowerShellEditorServices/Services/Workspace/WorkspaceService.cs
Outdated
Show resolved
Hide resolved
|
Issues
======
+ Solved 2
Clones added
============
- src/PowerShellEditorServices/Services/Workspace/WorkspaceService.cs 2
See the complete overview on Codacy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes PowerShell/vscode-powershell#2324
This removes any usage of
Uri.ToString()and creates aworspaceService.GetFile(that takes aUrito better abstract this away.This also revs the Omnisharp lib that contains my fix that also removes usages of
Uri.ToString()