legacy/1.x: Fix 'git cherry-pick' merge error causing pipelineIndentationStyle setting to not be correctly wired up #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmholt
approved these changes
Oct 2, 2019
|
When is it going to be released? |
|
Likely early next week. |
|
It's been over a month, this whitespace before/after brace problem is still there - any update when this will make it live? |
|
Apologies for the delay. There's one more PR we're trying to get in before we do the releases. It should happen in the next couple weeks. |
TylerLeonhardt
pushed a commit
that referenced
this pull request
Jan 8, 2020
…t got broken in #1024 (#1142) * Fix PipelineIndentation configuration issue (#1050) * legacy/1.x: Update minimum PSSA version to 1.18.3 (#1052) * Fix wiring of WhitespaceInsideBrace and WhitespaceAroundPipe * revert regression from master * add trailing comma * revert PSAvoidUsingCmdletAliases change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes PowerShell/vscode-powershell#2214
The backport PR #1024 did a correct cherry-pick but git did not merge the code change correctly and undid a line that was added in an earlier PR.
Locally verified.