Fix debugging deadlock (#807)

* fix debugger deadlock * revertBuildInfo * ignore BuildInfo changes forever
PowerShell · Dec 8, 2018 · ee227f1 · ee227f1
1 parent b5dc308
commit ee227f1
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/PowerShellEditorServices.build.ps1 b/PowerShellEditorServices.build.ps1
@@ -22,6 +22,9 @@ $script:TargetFrameworksParam = "/p:TargetFrameworks=\`"$(if (!$script:IsUnix) {
 $script:SaveModuleSupportsAllowPrerelease = (Get-Command Save-Module).Parameters.ContainsKey("AllowPrerelease")
 $script:BuildInfoPath = [System.IO.Path]::Combine($PSScriptRoot, "src", "PowerShellEditorServices.Host", "BuildInfo", "BuildInfo.cs")
 
+# ignore changes to this file
+git update-index --assume-unchanged "$PSScriptRoot/src/PowerShellEditorServices.Host/BuildInfo/BuildInfo.cs"
+
 if ($PSVersionTable.PSEdition -ne "Core") {
     Add-Type -Assembly System.IO.Compression.FileSystem
 }

diff --git a/src/PowerShellEditorServices.Protocol/MessageProtocol/Channel/NamedPipeServerListener.cs b/src/PowerShellEditorServices.Protocol/MessageProtocol/Channel/NamedPipeServerListener.cs
@@ -137,16 +137,16 @@ public override void Stop()
 
         private void ListenForConnection()
         {
-            var connectionTasks = new List<Task> {WaitForConnectionAsync(this.inOutPipeServer)};
-            if (this.outPipeServer != null)
-            {
-                connectionTasks.Add(WaitForConnectionAsync(this.outPipeServer));
-            }
-
-            Task.Run(async () =>
+            Task.Factory.StartNew(async () =>
             {
                 try
                 {
+                    var connectionTasks = new List<Task> {WaitForConnectionAsync(this.inOutPipeServer)};
+                    if (this.outPipeServer != null)
+                    {
+                        connectionTasks.Add(WaitForConnectionAsync(this.outPipeServer));
+                    }
+
                     await Task.WhenAll(connectionTasks);
                     this.OnClientConnect(new NamedPipeServerChannel(this.inOutPipeServer, this.outPipeServer, this.logger));
                 }