Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Check for case sensitivity rather than branching on OS type #1249

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

WIP: Check for case sensitivity rather than branching on OS type #1249

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9588e7f
Check for case sensitivity rather than branching on OS type
JamesWTruher Jun 3, 2019
24c388c
change scoping of case sensitive variable count
JamesWTruher Jun 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 27 additions & 3 deletions Tests/Engine/CustomizedRule.tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,31 @@
$testRootDirectory = Split-Path -Parent $directory
Import-Module (Join-Path $testRootDirectory 'PSScriptAnalyzerTestHelper.psm1')

# we need a way to determine whether the file system is case sensitive
# using $IsLinux or $IsMacOS is not sufficient
try
{
$module = get-module pester
# we can use the Pester New-TestDrive function
$d = & $module New-TestDrive -Pass
foreach ( $f in "file1","FILE2","fIlE3" ) {
$null = new-item -type file (Join-Path $d.root $f)
}
Write-Verbose -Verbose ("temp drive: " + $d.root)
$count = @(get-childitem (Join-Path $d.root "file?")).Count
if ( $count -eq 1 ) {
Write-Verbose -Verbose "Case Sensitive FS"
$script:CaseSensitiveFS = $true
} else {
Write-Verbose -Verbose "Case Insensitive FS"
$script:CaseSensitiveFS = $false
}
}
finally {
Remove-PSDrive $d
Remove-Item -force -recurse $d.root
}

if (-not (Test-PSEditionCoreCLR))
{
# Force Get-Help not to prompt for interactive input to download help using Update-Help
Expand Down Expand Up @@ -97,7 +122,7 @@ Describe "Test importing correct customized rules" {
It "will show the custom rules when given a glob" {
# needs fixing for Linux
$expectedNumRules = 4
if ($IsLinux)
if ($script:CaseSensitiveFS)
{
$expectedNumRules = 3
}
Expand All @@ -111,9 +136,8 @@ Describe "Test importing correct customized rules" {
}

It "will show the custom rules when given glob with recurse switch" {
# needs fixing for Linux
$expectedNumRules = 5
if ($IsLinux)
if ($script:CaseSensitiveFS)
{
$expectedNumRules = 4
}
Expand Down