Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change build to have -UseCFS switch otherwise uses crates-io #483

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

SteveL-MSFT
Copy link
Member

@SteveL-MSFT SteveL-MSFT commented Jul 4, 2024

PR Summary

Needed to change the build to replace crates-io with the powershell feed to be compliant, but if build.ps1 -UseCFS is NOT specified, we replace it back with crates-io. The change uses the equivalent env var as it takes precedence.
This will ensure that the release build is compliant while not impacting community builds or CI. This also removes the injected lines in config.toml that replaces with powershell feed since that is now the default in the config.toml file.

To pass compliance, cratesio registry has to be defined at runtime as an env var instead of being in the config.toml.

@SteveL-MSFT SteveL-MSFT requested review from anmenaga and tgauth July 4, 2024 02:57
@SteveL-MSFT SteveL-MSFT added this pull request to the merge queue Jul 10, 2024
Merged via the queue into PowerShell:main with commit 134960c Jul 10, 2024
4 checks passed
@SteveL-MSFT SteveL-MSFT deleted the cfs-default branch July 10, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants