Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separated WinPS adapter and tests #435

Merged
merged 3 commits into from
May 22, 2024
Merged

Conversation

anmenaga
Copy link
Contributor

@anmenaga anmenaga commented May 21, 2024

PR Summary

Having code for both PS6+ and WinPS adapters in same files is becoming too branchy and hard to maintain;
This PR:

  1. moves all WinPS adapter code into a separate files: win_psDscAdapter.psd1, win_psDscAdapter.psm1.
  2. WinPS adapter tests are moved out to win_powershellgroup.tests.ps1.
  3. PS6+ adapter code is cleaned, e.g. only class-based resources support is left
  4. Perf optimizations in PS6+ adapter:
    • only load PSDSC module when actually needed (happens only during cache refresh)
    • remove unnecessary Get-Module -ListAvailable call

PR Context

@anmenaga anmenaga requested a review from SteveL-MSFT May 21, 2024 17:10
@SteveL-MSFT SteveL-MSFT added this pull request to the merge queue May 22, 2024
Merged via the queue into PowerShell:main with commit f7ef3cb May 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants