add support to pass JSON as env var #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeltlombardi
added a commit
to michaeltlombardi/DSC
that referenced
this pull request
Sep 27, 2023
This change updates the schemas to replace the unimplemented `args` option for command input in the resource manifest with the `env` option. It also updates the schema and documentation to indicate that when the `input` option is not defined for a command in a resource manifest, DSC does not send the resource any input for that command. This update is made to reflect the changes from PowerShell#198.
michaeltlombardi
added a commit
to michaeltlombardi/DSC
that referenced
this pull request
Sep 27, 2023
This change updates the reference documentation and the changelog to reflect the changes that were included in the `alpha.3` release: - PowerShell#197 - PowerShell#198 - PowerShell#199
michaeltlombardi
added a commit
to michaeltlombardi/DSC
that referenced
this pull request
Sep 29, 2023
This change updates the reference documentation and the changelog to reflect the changes that were included in the `alpha.3` release: - PowerShell#197 - PowerShell#198 - PowerShell#199
michaeltlombardi
added a commit
to michaeltlombardi/DSC
that referenced
this pull request
Sep 29, 2023
This change updates the schemas to replace the unimplemented `args` option for command input in the resource manifest with the `env` option. It also updates the schema and documentation to indicate that when the `input` option is not defined for a command in a resource manifest, DSC does not send the resource any input for that command. This update is made to reflect the changes from PowerShell#198.
michaeltlombardi
added a commit
to michaeltlombardi/DSC
that referenced
this pull request
Sep 29, 2023
This change updates the reference documentation and the changelog to reflect the changes that were included in the `alpha.3` release: - PowerShell#197 - PowerShell#198 - PowerShell#199
michaeltlombardi
added a commit
to michaeltlombardi/DSC
that referenced
this pull request
Sep 30, 2023
This change updates the reference documentation and the changelog to reflect the changes that were included in the `alpha.3` release: - PowerShell#197 - PowerShell#198 - PowerShell#199
michaeltlombardi
added a commit
to michaeltlombardi/DSC
that referenced
this pull request
Sep 30, 2023
This change updates the reference documentation and the changelog to reflect the changes that were included in the `alpha.3` release: - PowerShell#197 - PowerShell#198 - PowerShell#199
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Enable passing JSON as env vars to command resource. Only strings, numbers, array of strings, array of numbers, or booleans are supported. Boolean array is excluded as it doesn't seem useful.
Note there is a change in behavior in that previously if
getin the resource manifest didn't specifyinput, it was assumedstdinand still passed through. However, ifinputis not defined, it's now assuming no input even if it was sent viastdin.PR Context
Fix #98