Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate model validation grid graphs with tikz #891

Merged
merged 7 commits into from
Feb 13, 2025

Conversation

mgovers
Copy link
Member

@mgovers mgovers commented Feb 7, 2025

No description provided.

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers added the documentation Improvements or additions to documentation label Feb 7, 2025
@mgovers mgovers requested a review from nitbharambe February 7, 2025 10:39
@mgovers mgovers self-assigned this Feb 7, 2025
@mgovers mgovers marked this pull request as ready for review February 7, 2025 10:42
@Jerry-Jinfeng-Guo
Copy link
Contributor

Copy link
Member

@nitbharambe nitbharambe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sizes needs reduction, rest is good.

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers requested a review from nitbharambe February 10, 2025 12:01
@mgovers mgovers dismissed nitbharambe’s stale review February 10, 2025 12:02

re-requesting. requested change causes approvals from other people to not be sufficient

docs/conf.py Outdated Show resolved Hide resolved
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Jerry-Jinfeng-Guo and others added 3 commits February 11, 2025 08:35
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers added this pull request to the merge queue Feb 13, 2025
Merged via the queue into main with commit 8d410ae Feb 13, 2025
28 checks passed
@mgovers mgovers deleted the feature/grid-graphs-with-tikz branch February 13, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants