Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auto tap validation test for meshed grid with transformers #777

Merged
merged 2 commits into from
Oct 11, 2024
Merged

auto tap validation test for meshed grid with transformers #777

merged 2 commits into from
Oct 11, 2024

Conversation

mgovers
Copy link
Member

@mgovers mgovers commented Oct 11, 2024

Add validation test for automatic tap adjustment for a meshed grid with transformers in the mesh

@TonyXiang8787 I added you as a reviewer as you requested

@mgovers
auto tap validation test for meshed grid with transformers
148c8f1 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers added the improvement Improvement on internal implementation label Oct 11, 2024
@mgovers mgovers requested a review from TonyXiang8787 October 11, 2024 11:34
@mgovers mgovers self-assigned this Oct 11, 2024
@mgovers
Copy link
Member Author

mgovers commented Oct 11, 2024 •
edited
Loading

docs build fails due to mgaitan/sphinxcontrib-mermaid#161 (fix in mgaitan/sphinxcontrib-mermaid#161 )

@mgovers
only check u_pu and u
a8a8dd0 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers marked this pull request as ready for review October 11, 2024 13:01
nitbharambe
nitbharambe approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@nitbharambe nitbharambe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets keep in mind to think of reusing input files for different outputs in future becomes a good idea. We now have many duplicate input files in all automatic tap changer cases.

@nitbharambe nitbharambe enabled auto-merge October 11, 2024 13:05
@nitbharambe nitbharambe disabled auto-merge October 11, 2024 13:05
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mgovers
Copy link
Member Author

mgovers commented Oct 11, 2024

@TonyXiang8787 awaiting your approval (no hurry)

@TonyXiang8787 TonyXiang8787 added this pull request to the merge queue Oct 11, 2024
Merged via the queue into main with commit e15588a Oct 11, 2024
26 checks passed
@TonyXiang8787 TonyXiang8787 deleted the feature/meshed-trafo-auto-tap-validation branch October 11, 2024 18:48
@mgovers mgovers mentioned this pull request Nov 5, 2024
Closed
27 tasks
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo mentioned this pull request Nov 11, 2024
Draft
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TonyXiang8787 TonyXiang8787 TonyXiang8787 approved these changes

@nitbharambe nitbharambe nitbharambe approved these changes

Assignees

@mgovers mgovers

Labels
improvement Improvement on internal implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgovers @TonyXiang8787 @nitbharambe