fix(plugin-server): Set transpileOnly when importing piscina code in tests #9777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tests Requiring our ts code took ~15 seconds on each worker thread every test. This change takes this down to 4.4s locally
417d580 to
7dba785
Compare
yakkomajuri
approved these changes
May 13, 2022
fuziontech
added a commit
that referenced
this pull request
May 13, 2022
* master: fix: exclusion steps cannot be selected (#9762) feat(lemon-button): Support `status` for `primary` buttons (#9782) fix: healthcheck for kafka on plugin server (#9771) fix(billing): Update billing success message (#9739) fix(plugin-server): Set transpileOnly when importing piscina code in tests (#9777) fix(plugin-server): Remove unused kafka reset test code (#9779) fix: set kafka_skip_broken_messages on dead letter queue table (#9754) fix(plugin-server): remove dead code from worker.test.ts (#9776) refactor(plugin-server): Run ingestion only on worker threads (#9738) fix: Plugin-server tests with kafka need to have consumer stopped (#9774) chore(deps): Update posthog-js to 1.21.1 (#9773) chore(dep): upgrading rr-web (#9772) fix: ouroboros inputs (#9769)
macobo
added a commit
that referenced
this pull request
May 18, 2022
Every time we run jest tests, typescript is being compiled. This adds ~13-20s to _starting_ each test suite on my machine. This change brings it down to 1s at the cost of only _transpiling_ the code and not doing any typechecking. The second overhead this fixes is for piscina: every worker thread compiled its own code every time, speeding this up takes that from 4.4s to under a second. See #9777 for original context
macobo
added a commit
that referenced
this pull request
May 18, 2022
* feat(plugin-server): use swc for running jest tests Every time we run jest tests, typescript is being compiled. This adds ~13-20s to _starting_ each test suite on my machine. This change brings it down to 1s at the cost of only _transpiling_ the code and not doing any typechecking. The second overhead this fixes is for piscina: every worker thread compiled its own code every time, speeding this up takes that from 4.4s to under a second. See #9777 for original context * Re-add ts-jest
alexkim205
pushed a commit
that referenced
this pull request
May 23, 2022
…tests (#9777) Requiring our ts code took ~15 seconds on each worker thread every test. This change takes this down to 4.4s locally
alexkim205
pushed a commit
that referenced
this pull request
May 23, 2022
* feat(plugin-server): use swc for running jest tests Every time we run jest tests, typescript is being compiled. This adds ~13-20s to _starting_ each test suite on my machine. This change brings it down to 1s at the cost of only _transpiling_ the code and not doing any typechecking. The second overhead this fixes is for piscina: every worker thread compiled its own code every time, speeding this up takes that from 4.4s to under a second. See #9777 for original context * Re-add ts-jest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requiring our ts code took ~15 seconds on each worker thread every test, which in turn blocks getting plugin schedules during server setup.
This change takes this down to 4.4s locally.