Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(column-configurator): convert to using the taxonomic filter #8726

Merged
merged 38 commits into from
Mar 7, 2022
Merged

fix(column-configurator): convert to using the taxonomic filter #8726

Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
d121a0f
copy array in selector to trigger change detection
pauldambra Feb 23, 2022
689b2e8
use taxonomic filter for the column configurator
pauldambra Feb 24, 2022
10770fc
fix column configurator tests
pauldambra Feb 24, 2022
de18065
fix weird test failure
pauldambra Feb 25, 2022
16bff88
ensure the taxonomic popup isn't showing row 0 when then column confi…
pauldambra Feb 25, 2022
d135e1a
rename visible columns now there are no hidden columns
pauldambra Feb 25, 2022
df30ad3
rename visible columns now there are no hidden columns
pauldambra Feb 25, 2022
ea8bb34
tidy up column configurator
pauldambra Feb 26, 2022
ebddc4a
which allows removal of a use of the property definitions model
pauldambra Feb 26, 2022
f674c28
Merge branch 'master' into empty-columns
pauldambra Mar 2, 2022
757e7d6
more specific prop to disable popper on taxonomic filter
pauldambra Mar 2, 2022
e389bee
better column name
pauldambra Mar 2, 2022
918f9ab
don't allow duplicate column selections
pauldambra Mar 2, 2022
7e730af
Merge branch 'master' into empty-columns
pauldambra Mar 2, 2022
6ddc641
use autosizer height and width and flex display to have infinite list…
pauldambra Mar 2, 2022
5587ae4
set text overflow for long rows in the infinite list
pauldambra Mar 3, 2022
bab97a7
update column configurator columns when resetting
pauldambra Mar 3, 2022
8cf08c5
Merge branch 'master' into empty-columns
pauldambra Mar 4, 2022
9982f01
select initial row based on props
pauldambra Mar 4, 2022
f58b2af
don't create css if height and width are not provided
pauldambra Mar 4, 2022
0bae446
limit scope of change to propertykeyinfo width
pauldambra Mar 4, 2022
32c17c0
alter column configurator reset behaviour
pauldambra Mar 4, 2022
ac1d347
set popper enabled without breaking text search
pauldambra Mar 4, 2022
016f866
don't need to pass popper enabled two different ways to infinite list
pauldambra Mar 4, 2022
bf26aea
allow taxonomic filter value consumers to configure it not to clear s…
pauldambra Mar 4, 2022
21500ad
clear the taxonomic filter search when the column configurator is saved
pauldambra Mar 4, 2022
e91c407
fix tests
pauldambra Mar 4, 2022
ce40e3a
default column configurator to an empty array of columns
pauldambra Mar 4, 2022
ceb69c8
Revert "default column configurator to an empty array of columns"
pauldambra Mar 4, 2022
2198563
Revert "fix tests"
pauldambra Mar 4, 2022
b040f04
Revert "clear the taxonomic filter search when the column configurato…
pauldambra Mar 4, 2022
1755198
rename popper to popover
pauldambra Mar 4, 2022
ce85c12
move taxonomic filter config onto its props
pauldambra Mar 4, 2022
b0ead05
tidier declaration of style
pauldambra Mar 4, 2022
1ab117b
make selecting the first item explicit
pauldambra Mar 4, 2022
3504c00
always clear taxonomic filter on select but do it so infinite list ca…
pauldambra Mar 4, 2022
a3232d1
fix tests
pauldambra Mar 4, 2022
e0653e6
use the constant for no item selected, since it is available
pauldambra Mar 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/models/propertyDefinitionsModel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ export const propertyDefinitionsModel = kea<
],
propertyDefinitions: [
(s) => [s.propertyStorage],
(propertyStorage): PropertyDefinition[] => propertyStorage.results || [],
(propertyStorage): PropertyDefinition[] => [...propertyStorage.results] || [],
],
transformedPropertyDefinitions: [
// Transformed propertyDefinitions to use in `Select` components
Expand Down