Don't create datepicker input as readonly #8644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pauldambra not sure if this is the right place to raise this issue but after testing it there are two issues:
recording_20220216-174555.mp4 |
|
That second problem is almost certainly this issue #7970 Very frustrating! |
EDsCODE
added a commit
that referenced
this pull request
Feb 16, 2022
* master: (48 commits) refactor update public jobs query (#8596) revert use atomics flag (#8575) fix max retries (#8647) Remove weekly email code (#8643) Set default value not value (#8644) Add ECS plugin server healthcheck (#8642) Query person_distinct_id2 not person_distinct_id (#8358) increase isNewPerson TTL to 4 hours (#8637) Refactor exportEvents buffer (#8573) Remove dead actions endpoint code (#8625) drop unused functions if instances have them (#8565) Disable browsable API outside of DEBUG (#8635) update dlq metrics order (#8636) Make self capture robust to errors (#8629) Delete old events-model adjacent code (#8623) Increase viewport size (#8632) Revert "Use insight short ID in `insightLogic` key also on the insight page (#8613)" (#8631) detect response error status of 0 as an error too (#8603) Allow disabling a plugin's logs (#8519) fix dlq logic for pagination (#8627) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ANTD datepicker has both value and default value.
Setting value makes the input readonly. This didn't cause any issue when the picker was in a pop-up on the events page or a global filter on an insight. But in a series-specific filter it appeared you couldn't change the input even though the value was actually changing (e.g. correct network call was being made)
Before
After
How did you test this code?
By running it locally and setting and changing date time filters