Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor old cohort event selector #8416

Merged
merged 5 commits into from
Feb 3, 2022
Merged

Conversation

mariusandra
Copy link
Collaborator

Changes

Removes something ancient.

Before:
image

After: (ignore the empty action in the list)
2022-02-03 13 15 33

Other changes:

  • Splits out TaxonomicStringPopup from TaxonomicPopup if you don't want to deal with a string | number type for all the onChange events. Makes things a bit easier.
  • Adds the full-width class to the filter, because I kept adding a style='width:100%' tag to all new filters
  • Creates a helper findActionName to find an action's name easily

How did you test this code?

Tried creating cohorts in the interface. Things worked. Hoping E2E tests also work.

@mariusandra
Copy link
Collaborator Author

Should have done reviews first... this was already done in:

@pauldambra pauldambra merged commit 28a16fe into master Feb 3, 2022
@pauldambra pauldambra deleted the refactor-cohort-event-list branch February 3, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants