Refactor old cohort event selector #8416
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Removes something ancient.
Before:
![image](https://user-images.githubusercontent.com/53387/152004343-6daa450c-6b40-4ede-909d-b52f9ff7ef92.png)
After: (ignore the empty action in the list)
![2022-02-03 13 15 33](https://user-images.githubusercontent.com/53387/152340979-a7c14ba3-1584-4893-b95a-aa3b68d6daa3.gif)
Other changes:
TaxonomicStringPopup
fromTaxonomicPopup
if you don't want to deal with astring | number
type for all the onChange events. Makes things a bit easier.full-width
class to the filter, because I kept adding astyle='width:100%'
tag to all new filtersfindActionName
to find an action's name easilyHow did you test this code?
Tried creating cohorts in the interface. Things worked. Hoping E2E tests also work.