Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dashboard with all possible insight types into Storybook #7017

Merged
merged 5 commits into from
Dec 10, 2021

Conversation

mariusandra
Copy link
Collaborator

@mariusandra mariusandra commented Nov 10, 2021

Changes

How did you test this code?

  • Looking at the stories in storybook.

@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@hazzadous
Copy link
Contributor

@mariusandra I've been adding insights stories as I go if it's useful, retention is probably the most likely to be functional

If there's a Dashboard I should also progressively add these too I can do so as well?

@mariusandra
Copy link
Collaborator Author

This PR is a first attempt at making such a dashboard. Feel free to pick it up, strip out whatever doesn't make sense, and add for example the retention graphs.

Sitecomment: I suggest using combineUrl(path, searchParams, hashParams).url from kea-router instead of URLSearchParams. It's what powers all the URL manipulation in the frontend (yay for increased parity), and you'll be able to skip all the JSON.stringify calls.

@posthog-bot posthog-bot removed the stale label Dec 8, 2021
@mariusandra
Copy link
Collaborator Author

This PR has been stale for over 2 weeks, and contains a storybook dashboard I never had the chance to finish.

The idea was for it to contain all possible insights, but it now has just three:

image

I'll merge this in, since we currently have no dashboards in storybook, and we can add more charts as time goes on.

@mariusandra mariusandra marked this pull request as ready for review December 10, 2021 10:39
@mariusandra mariusandra merged commit a8f0091 into master Dec 10, 2021
@mariusandra mariusandra deleted the storybook-dashboard branch December 10, 2021 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants