-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turbo mode #6632
Merged
Merged
Turbo mode #6632
Changes from all commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
7a65d0a
fix router redirect
mariusandra d32f1e5
remove dependence on user var
mariusandra 5a57bfe
split scenes and sceneTypes out of sceneLogic
mariusandra 7b34ce5
rename LoadedScene type to SceneExport
mariusandra 4b06966
export SceneExport from most scenes
mariusandra 7687d50
use exported scene objects, warn if not exported
mariusandra 552c32b
fix type import bugs
mariusandra 02fd494
remove dashboard
mariusandra 6142de3
keep all loaded scene logics in memory
mariusandra a59c8ca
fix sorting bugs
mariusandra 06e1925
support scenes with params, make it work with dashboards
mariusandra b9bd996
fetch result from dashboard if mounted
mariusandra a70d2cc
fix mutations
mariusandra 7ff8d5c
add lastTouch
mariusandra 586ab57
refactor scene parameters to include searchParams and hashParams
mariusandra eac2144
add insights scene to scene router
mariusandra 6c2826b
add insight router scene to scene router
mariusandra b2bb205
fix cohort back/forward bug
mariusandra 5071e16
this works
mariusandra eacdcf6
bring back delayed loading of scenes
mariusandra dc1b3fd
set insight from dashboard also in afterMount
mariusandra cabbf70
split events, actions, event stats and properties stats into their ow…
mariusandra 5b62e40
refactor to options object for setInsight
mariusandra a5388e9
override filters
mariusandra 48f01a6
clean filters for comparison
mariusandra 62ec657
fix cohort bug
mariusandra 1263efc
get a better feature flag
mariusandra e6365ad
make turbo mode faster by making non-turbo-mode slower
mariusandra 5b91940
less noise in failed tests
mariusandra b2342ea
fix tests
mariusandra cd91ebe
flyby: add jest tests pycharm launcher
mariusandra 7185037
clean up scenes
mariusandra f9dc482
add test for loading from dashboardLogic
mariusandra f652dd4
Merge branch 'master' into turbo-mode
mariusandra 295f23c
fix bug
mariusandra 43d06f5
split test init code into two
mariusandra 0a52aeb
have the same data in the context and in the api
mariusandra 9accb24
add basic tests for sceneLogic
mariusandra e801148
run the latest and greatest
mariusandra 3853f17
fix menu highlight
mariusandra 5580a67
implement screaming snake
mariusandra 2ee3a17
only show scenes with logics
mariusandra 26816f9
Merge branch 'master' into turbo-mode
mariusandra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
<component name="ProjectRunConfigurationManager"> | ||
<configuration default="false" name="Jest Tests" type="JavaScriptTestRunnerJest"> | ||
<node-interpreter value="project" /> | ||
<node-options value="" /> | ||
<jest-package value="$PROJECT_DIR$/node_modules/jest" /> | ||
<working-dir value="$PROJECT_DIR$" /> | ||
<envs /> | ||
<scope-kind value="ALL" /> | ||
<method v="2" /> | ||
</configuration> | ||
</component> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flyby fix to a bug, where if you click to open a cohort, and then click back, the URL will change, but the cohort drawer will remain open.