feat(trends): add moving average smoothing_intervals param
#6435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will average over the preceding `smoothing_intervals` intervals. The driver for this is to remove either weekly or monthly trends. Limitations at the moment are that it only works for total volume queries, as it relies on the results from clickhouse being from a single timeline series.
5ad093c to
d871824
Compare
neilkakkar
reviewed
Oct 15, 2021
This should allow for url navigation to work, although I haven't quite figured out how we then use this to make the insights/trends POST request
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
|
This PR was closed due to 2 weeks of inactivity. Feel free to reopen it if still relevant. |
|
Thanks @mariusandra! Every time you re-open this I get more embarrassed about my incredibly slow pace on this PR. Will try harder. |
|
I'm going to close this, if someone picks the task up they can open up a PR themselves. |
|
Cool. Going to pick this up within the next week or so. Leaving a note here for record |
EDsCODE
reviewed
Mar 23, 2022
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will average over the preceding
smoothing_intervalsintervals.The driver for this is to remove either weekly or monthly trends.
Limitations at the moment are that it only works for total volume
queries, as it relies on the results from clickhouse being from a single
timeline series.
Video example here