Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Path step limit param #5675

Merged
merged 4 commits into from
Aug 23, 2021
Merged

Path step limit param #5675

merged 4 commits into from
Aug 23, 2021

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Aug 20, 2021

Changes

Please describe.

  • adds parameter support for variable path length
    If this affects the frontend, include screenshots.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests
  • Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious
  • New/changed UI is decent on smartphones (viewport width around 360px)

@timgl timgl temporarily deployed to posthog-pr-5675 August 20, 2021 20:06 Inactive
@EDsCODE EDsCODE requested a review from neilkakkar August 23, 2021 03:38
@neilkakkar neilkakkar enabled auto-merge (squash) August 23, 2021 10:11
@timgl timgl temporarily deployed to posthog-pr-5675 August 23, 2021 11:09 Inactive
@neilkakkar neilkakkar merged commit 04b751e into master Aug 23, 2021
@neilkakkar neilkakkar deleted the path-step-limit-param branch August 23, 2021 11:53
@EDsCODE EDsCODE requested a review from liyiy August 23, 2021 14:39
@EDsCODE EDsCODE mentioned this pull request Sep 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilkakkar neilkakkar neilkakkar approved these changes

@liyiy liyiy Awaiting requested review from liyiy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EDsCODE @neilkakkar @timgl