Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report properties on insight viewed #5511

Merged
merged 3 commits into from
Aug 13, 2021
Merged

Report properties on insight viewed #5511

merged 3 commits into from
Aug 13, 2021

Conversation

paolodamico
Copy link
Contributor

@paolodamico paolodamico commented Aug 9, 2021 •
edited
Loading

Changes

This PR adds three properties to the insight viewed (and insight analyzed) events to track usage on specific PostHog-based properties. This will provide context on what to do about #5312.

Note that custom property names will not be sent (they're marked as redacted for privacy reasons).

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests
  • Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious
  • New/changed UI is decent on smartphones (viewport width around 360px)

@paolodamico paolodamico requested a review from liyiy August 9, 2021 11:58
@timgl timgl temporarily deployed to posthog-pr-5511 August 9, 2021 12:00 Inactive
@paolodamico paolodamico requested a review from kpthatsme August 12, 2021 21:08
kpthatsme
kpthatsme approved these changes Aug 13, 2021
View reviewed changes
Copy link
Contributor

@kpthatsme kpthatsme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One non-blocking question, lgtm!

@timgl timgl temporarily deployed to posthog-pr-5511 August 13, 2021 17:38 Inactive
@timgl timgl temporarily deployed to posthog-pr-5511 August 13, 2021 17:40 Inactive
@paolodamico paolodamico enabled auto-merge (squash) August 13, 2021 17:41
@paolodamico paolodamico merged commit bb458ed into master Aug 13, 2021
@paolodamico paolodamico deleted the report-properties-insight-viewed branch August 13, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpthatsme kpthatsme kpthatsme approved these changes

@liyiy liyiy Awaiting requested review from liyiy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paolodamico @kpthatsme @timgl