Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix persons modal loading #5190

Merged
merged 1 commit into from
Jul 19, 2021
Merged

Fix persons modal loading #5190

merged 1 commit into from
Jul 19, 2021

Conversation

liyiy
Copy link
Contributor

@liyiy liyiy commented Jul 19, 2021

Changes

Please describe.
If this affects the frontend, include screenshots.

The setPeopleLoading action call might've been accidentally deleted during a merge? Adding it back in so the loading state actually happens~

Screen.Recording.2021-07-18.at.8.14.57.PM.mov

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests
  • Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious
  • New/changed UI is decent on smartphones (viewport width around 360px)

@timgl timgl temporarily deployed to posthog-pr-5190 July 19, 2021 00:17 Inactive
@liyiy liyiy requested review from paolodamico and samwinslow July 19, 2021 13:04
paolodamico
paolodamico approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@paolodamico paolodamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@paolodamico paolodamico merged commit 20ed19a into master Jul 19, 2021
@paolodamico paolodamico deleted the fix-persons-modal-loading branch July 19, 2021 14:05
@paolodamico paolodamico mentioned this pull request Jul 19, 2021
Merged
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paolodamico paolodamico paolodamico approved these changes

@samwinslow samwinslow Awaiting requested review from samwinslow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liyiy @paolodamico @timgl