Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date filter range UI bug #4746

Merged
merged 1 commit into from
Jun 14, 2021
Merged

Date filter range UI bug #4746

merged 1 commit into from
Jun 14, 2021

Conversation

liyiy
Copy link
Contributor

@liyiy liyiy commented Jun 14, 2021

Changes

Closes #4345
Re-order the config options so that date filter doesn't get cut off

Screen Shot 2021-06-14 at 3 21 00 PM

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests
  • Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious
  • Frontend/CSS is usable at 320px (iPhone SE) and decent at 360px (most phones)

@liyiy liyiy requested a review from samwinslow June 14, 2021 19:23
@timgl timgl temporarily deployed to posthog-pr-4746 June 14, 2021 19:27 Inactive
@liyiy liyiy requested a review from alexkim205 June 14, 2021 21:03
@liyiy liyiy merged commit 040458f into master Jun 14, 2021
@liyiy liyiy deleted the 4345-datefilterrange-bug branch June 14, 2021 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samwinslow samwinslow Awaiting requested review from samwinslow

@alexkim205 alexkim205 Awaiting requested review from alexkim205

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DateFilterRange inputs too small for content
2 participants
@liyiy @timgl