Fix bug where we can't see counts in Insight Table

[alexkim205]

Changes

Fixes #2983

Checklist

• All querysets/queries filter by Organization, by Team, and by User
• Django backend tests
• Jest frontend tests
• Cypress end-to-end tests
• Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious
• Frontend/CSS is usable at 320px (iPhone SE) and decent at 360px (most phones)

[paolodamico]

Think it's worth considering already changes from #4700

[alexkim205]

Think it's worth considering already changes from #4700

That PR is so nice, love the UI changes. I think my fix in this PR would still apply because I'm not editing the InsightsTable component itself, rather just passing the filter into the <BindLogic/> which wraps both <InsightsTableV1/> and <InsightsTableV2/>.

I'm also going to generalize the cypress tests in my PR so that we don't have to touch them again once we move from V1 to V2.

[mariusandra]

Is this bugfix something we want to feature flag? 🤔

[paolodamico]

We're not feature flagging the bug fix, showTotalCount is used to determine if we should display the new total count column in the table view, so I think it's fine.

[mariusandra]

Yeah, but we just show it to those who are using the new experimental UI, even though the bug is there for everyone

[mariusandra]

I'm probably doing something dumb here, but with this query

a) if I have no feature flags enabled, I see just a broken table
b) if I have the new tooltips flag enabled, I see this:

even if there is actually some data:

[alexkim205]

@mariusandra

a. The bug exists in both the old and new ui, so hiding this behind a feature flag doesn't make sense. I'll remove that check.
b. I clicked the link with the feature flag enabled but can't reproduce the issue. I tried to use some data that had similar shape (where data only exists on last day) here but it looks like all the data's there 🤔