-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin editor types #4468
Plugin editor types #4468
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a problem in that this doesn't build
import { Plugin } from '@posthog/plugin-scaffold' | ||
|
||
type MyPluginType = Plugin<{ | ||
config: {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should match defaultConfig
.
So, feedback addressed and it builds now. Still some issues with this PR. Not sure if they are blockers or not:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
As for improvements, I'd say nothing blocking. May be worth creating issue for some e.g. ensuring plugin-scaffold
is up to date.
Changes
@posthog/plugin-scaffold
types into the plugin source editor for sweet TypeScript supportChecklist