Save Organization.available_features as a DB column #4426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
paolodamico
approved these changes
May 21, 2021
| from posthog.models.organization import Organization | ||
|
|
||
|
|
||
| def sync_all_organization_available_features() -> None: |
There was a problem hiding this comment.
Nit: naming sync_all_organizations_available_features
There was a problem hiding this comment.
This is more of "Sync all Organization.available_features", I think I'll leave as is
| @receiver(models.signals.pre_save, sender=Organization) | ||
| def organization_about_to_be_created(sender, instance: Organization, raw, using, **kwargs): | ||
| if instance._state.adding: | ||
| instance.update_available_features() |
There was a problem hiding this comment.
Maybe worth just updating this particular org?
There was a problem hiding this comment.
WDYM? That does seem to be the case already?
This reverts commit 421e854.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Closes #4408 (a prerequisite for PostHog/plugin-server#235).
Makes
Organization.available_featuresa model field (Postgres column) instead of a dynamically calculated property. This way the features-determination logic only has to run occasionally, and the results are available in the database, so the plugin server can use them too.The field is updated (with
organization.update_available_features()) in the following circumstances:Checklist