Dashboard item page view

[liyiy]

Changes

Updating the dashboard item view page first before adding edit mode and then history panel for #3551

When you click on a dashboard item from the dashboards page, it's now clearer that it's a dedicated dashboard item page

BEFORE:

AFTER:

Checklist

• All querysets/queries filter by Organization, by Team, and by User
• Django backend tests
• Jest frontend tests
• Cypress end-to-end tests
• Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious

[paolodamico]

Nice stuff! Code-wise looks pretty solid, just made a comment on the way we pass params in the query string and one nit comment. Pushed a very minor commit with some comment clarifications, seemed faster than adding a review comment.

Functionality wise just found a problem. When you open a saved insight from the History tab, it shows like this (as in it says "On dashboard" but it's not actually part of a dashboard).

UI wise we had this design, sorry if we missed linking it in the original issue, which I think would be pretty nice to add (let me know if you want me to help here). One small change, I do love what you did of replacing the "Insights" title with the name of the item, I would keep that.

[liyiy]

Closing while I implement changes :D

[EDsCODE]

Not sure if you meant for review yet but was taking a look at the implementation and leaving my 2 🪙. Overall looks great only 2 points for a UI perspective

1. The CTA button "add to dashboard" should be context aware and only say "Save changes". The changes should be saved to the dashboard_item in view
2. +1 to Paolo's comment about urls. I thought about it and I think it'd be really concise if we could get specific insights that already exist as tracked entities to just have a url of /insights/{dashboard_item_id} (e.g. /insisghts/25)

Great work so far

[liyiy]

It was a bit of a pain to reroute the Insights History with the new insights/${id} links so I'm leaving it as it was originally (for now) to maintain functionality.

[liyiy]

Updates include:

1. Fixing the dashboard item "Update Dashboard" button
2. Rerouting the dashboard item links to go to /insights/${id}

[paolodamico]

Hey @liyiy! Let me know if you want me to re-review

[liyiy]

My PR is getting huge, so I would like to clean/touch up what I have now if it's working fine and then open a new PR to make more updates 😅 Otherwise feel free to lay any suggestions if the high level approach doesn't seem correct

[paolodamico]

Honestly this looks amazing! A few comments but nothing blocking. Feel free to address what you think makes sense.

UX wise I did notice an issue.

1. When visiting an insight from the history panel, the back button will not work as expected (as we do some URL changes that add an extra step to the history state). You would have to click back twice for it to work.