Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Round table rows in system status #3883

Merged
merged 5 commits into from
Apr 7, 2021
Merged

Round table rows in system status #3883

merged 5 commits into from
Apr 7, 2021

Conversation

mariusandra
Copy link
Collaborator

Changes

Before:
image

After:
image

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@mariusandra mariusandra requested a review from Twixes April 6, 2021 09:00
@mariusandra mariusandra temporarily deployed to posthog-pr-3883 April 6, 2021 09:11 Inactive
@mariusandra mariusandra temporarily deployed to posthog-pr-3883 April 6, 2021 09:25 Inactive
@Twixes Twixes temporarily deployed to posthog-pr-3883 April 7, 2021 12:37 Inactive
Twixes
Twixes approved these changes Apr 7, 2021
View reviewed changes
Copy link
Member

@Twixes Twixes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already had similar compact_number, which was a bit less elegant though, so I renamed the newer human_format to compact_number and removed the older one. Merge if this looks good to you too

@Twixes Twixes temporarily deployed to posthog-pr-3883 April 7, 2021 13:04 Inactive
@mariusandra mariusandra merged commit e068568 into master Apr 7, 2021
@mariusandra mariusandra deleted the round-rows branch April 7, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Twixes Twixes Twixes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariusandra @Twixes