-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global hotkey navigation #3740
Global hotkey navigation #3740
Conversation
I would love to get particularly input on both the concept of the tooltip message for the navigation bar items, and the actual copy. Want to make sure it's helpful and not intrusive. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One feature flag check bug and some thoughts.
Alright all feedback addressed, ready for a final look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I was playing around with a way to make them a little more subtle in the nav tooltips. (This eliminated the need for the "Keyboard navigation" label.) As for the prominence for the analysis views, I sort of agree with Marius. I did a quick version to see if we can make them blend a bit more and here was my attempt: |
Changes
This PR introduces global hotkey navigation to make our overall experience smoother for power users. Everything is behind feature flag
hotkeys-3740
.remove-shownas
is enabled).In addition this PR:
Insights.tsx
to Typescript and fixes a bunch of Typescript errors.Checklist