Temporarily bring back individual refresh in dashboard items #3708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paolodamico I'm testing this on the deploy right now – it looks like the underlying dataset refreshes but it looks like timestamps aren't being updated when hovering over the tooltip on chart tiles |
|
Thanks for the review @kpthatsme, yeah that's what I first discovered in #3609, timestamps are not updated consistently every time. I think we could ship this in the meantime while we figure out the other bug. @macobo maybe you'd be able to help us with this? I think you have more context on that. I can take a deeper look next week otherwise. |
|
@paolodamico that sounds good to me! Definitely still feels like an improvement since data is refreshing. Thanks! |
|
No problem! Will try to take a look later today too with fresh eyes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Re-enables individually refreshing dashboard items. Full context here, #3609
Checklist