Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint Dockerfiles #3663

Merged
merged 14 commits into from
Mar 18, 2021
Merged

Lint Dockerfiles #3663

merged 14 commits into from
Mar 18, 2021

Conversation

Twixes
Copy link
Member

@Twixes Twixes commented Mar 16, 2021

Changes

Let's up our Docker game. We need to ensure security and cleanliness and Hadolint is an interesting tool in this area – it's a Dockerfile linter with some sensible rules.

@Twixes Twixes changed the title Lint with Hadolint in Docker test workflow Lint Dockerfiles Mar 16, 2021
@Twixes Twixes temporarily deployed to posthog-hadolint-k8noygggwwtww March 16, 2021 01:12 Inactive
@Twixes Twixes temporarily deployed to posthog-hadolint-k8noygggwwtww March 16, 2021 01:15 Inactive
@Twixes Twixes temporarily deployed to posthog-hadolint-k8noygggwwtww March 16, 2021 01:34 Inactive
@Twixes Twixes temporarily deployed to posthog-hadolint-k8noygggwwtww March 16, 2021 01:37 Inactive
@Twixes Twixes temporarily deployed to posthog-hadolint-k8noygggwwtww March 16, 2021 01:39 Inactive
@Twixes Twixes temporarily deployed to posthog-hadolint-k8noygggwwtww March 16, 2021 01:46 Inactive
@Twixes Twixes temporarily deployed to posthog-hadolint-k8noygggwwtww March 16, 2021 13:49 Inactive
@Twixes Twixes temporarily deployed to posthog-hadolint-k8noygggwwtww March 16, 2021 14:38 Inactive
@Twixes Twixes temporarily deployed to posthog-hadolint-k8noygggwwtww March 16, 2021 15:06 Inactive
@Twixes Twixes requested a review from fuziontech March 16, 2021 15:11
Copy link
Member

@fuziontech fuziontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. I'm not a dockerfile security or best practices expert so this will help a ton to keep us from doing something bad.

image

@Twixes Twixes merged commit 9f24da6 into master Mar 18, 2021
@Twixes Twixes deleted the hadolint branch March 18, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants