fix: empty scene div causing dom flow to change if neither conditions are met #29109
+83
−13
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,64 @@ | ||||||||
| import { LemonCheckbox, LemonSwitch } from '@posthog/lemon-ui' | ||||||||
| import { Meta } from '@storybook/react' | ||||||||
| import { LemonInput } from 'lib/lemon-ui/LemonInput/LemonInput' | ||||||||
| import { LemonRadio } from 'lib/lemon-ui/LemonRadio/LemonRadio' | ||||||||
| import { LemonSlider } from 'lib/lemon-ui/LemonSlider/LemonSlider' | ||||||||
| import { useState } from 'react' | ||||||||
|
|
||||||||
| const meta: Meta = { | ||||||||
| title: 'Design System/Inputs', | ||||||||
| tags: ['autodocs'], | ||||||||
| } | ||||||||
| export default meta | ||||||||
|
|
||||||||
| function GetAllInputs(): JSX.Element { | ||||||||
|
There was a problem hiding this comment. style: Function name 'GetAllInputs' does not follow camelCase convention used elsewhere in codebase |
||||||||
| const [checked, setChecked] = useState(false) | ||||||||
| const [radioValue, setRadioValue] = useState('this') | ||||||||
|
|
||||||||
| return ( | ||||||||
| <div className="flex flex-col gap-2"> | ||||||||
| <LemonInput /> | ||||||||
| <LemonInput placeholder="Placeholder" /> | ||||||||
| <LemonInput disabled /> | ||||||||
| <LemonInput disabled /> | ||||||||
|
Comment on lines
+22
to
+23
There was a problem hiding this comment. logic: Duplicate disabled LemonInput component with identical props
Suggested change
|
||||||||
| <LemonInput value={"I'm pre-filled"} /> | ||||||||
| <LemonSlider max={100} min={0} value={50} /> | ||||||||
|
There was a problem hiding this comment. logic: LemonSlider lacks onChange handler, making it non-interactive in Storybook |
||||||||
| <LemonCheckbox label="Checkbox" /> | ||||||||
| <LemonCheckbox label="Checkbox" disabledReason="This is not the way to Amarillo" /> | ||||||||
| <LemonCheckbox label="Checkbox" checked /> | ||||||||
| <LemonRadio | ||||||||
| value={radioValue} | ||||||||
| options={[ | ||||||||
| { label: 'This', value: 'this' }, | ||||||||
| { label: 'That', value: 'that' }, | ||||||||
| ]} | ||||||||
| onChange={setRadioValue} | ||||||||
| /> | ||||||||
| <LemonRadio | ||||||||
| value={radioValue} | ||||||||
| options={[ | ||||||||
| { label: 'This', value: 'this', disabledReason: 'This is not the way to Amarillo' }, | ||||||||
| { label: 'That', value: 'that' }, | ||||||||
| ]} | ||||||||
| onChange={setRadioValue} | ||||||||
| /> | ||||||||
| <LemonSwitch checked={checked} onChange={() => setChecked(!checked)} /> | ||||||||
| <LemonSwitch checked={checked} bordered onChange={() => setChecked(!checked)} /> | ||||||||
| <LemonSwitch checked={true} disabledReason="This is not the way to Amarillo" /> | ||||||||
| <LemonSwitch checked={false} /> | ||||||||
| <LemonSwitch checked={false} bordered /> | ||||||||
| <LemonSwitch checked={false} disabledReason="This is not the way to Amarillo" /> | ||||||||
| </div> | ||||||||
| ) | ||||||||
| } | ||||||||
|
|
||||||||
| export const AllInputs = (): JSX.Element => { | ||||||||
| return ( | ||||||||
| <div className="space-y-2"> | ||||||||
| <div className="bg-primary p-4">{GetAllInputs()}</div> | ||||||||
| <div className="bg-surface-primary p-4">{GetAllInputs()}</div> | ||||||||
| <div className="bg-surface-secondary p-4">{GetAllInputs()}</div> | ||||||||
| <div className="bg-surface-tertiary p-4">{GetAllInputs()}</div> | ||||||||
| </div> | ||||||||
| ) | ||||||||
| } | ||||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Consider using Tailwind's conditional classes with clsx here instead of ternary operator for consistency with other className assignments in the file