Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ::placeholder for input and textarea lighter #29102

Merged
merged 1 commit into from
Feb 22, 2025

Conversation

adamleithp
Copy link
Contributor

@adamleithp adamleithp commented Feb 22, 2025

Problem

Placeholder color for input/textarea was too dark/too high contrast (people were confusing placeholder with a value)

Changes

Made placeholder color lighter (less contrast)
AAA contrast => AA constrast (it's fine)

2025-02-22 17 38 23

Text tertiary (in change) is the the lowest contrast we can have before it drops below AA WCAG ratings

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Locally

@adamleithp adamleithp marked this pull request as ready for review February 22, 2025 16:24
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Changed placeholder text color in inputs and textareas from --text-secondary to --text-tertiary to reduce contrast and better differentiate between placeholder text and actual input values.

  • Modified frontend/src/styles/base.scss to use --text-tertiary for ::placeholder pseudo-element, maintaining AA accessibility standards while improving visual distinction
  • Change affects both Cloud and self-hosted environments consistently

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

Size Change: 0 B

Total Size: 9.71 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 9.71 MB

compressed-size-action

@HamedMP HamedMP self-requested a review February 22, 2025 17:18
@adamleithp adamleithp merged commit 501bf5b into master Feb 22, 2025
100 of 101 checks passed
@adamleithp adamleithp deleted the devex/input-placeholder-lighter branch February 22, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants