Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use correct env. ID when listing groups in a project #29100

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

spaceemotion
Copy link

@spaceemotion spaceemotion commented Feb 22, 2025

Problem

Closes #29099

Changes

Using a debugger I was able to trace back which ID should be the correct one. For the changes, I used a different frontend file as guidance:

Does this work well for both Cloud and self-hosted?

No impact.

How did you test this code?

No tests have been made as I don't have a local PostHog installation.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR fixes a critical issue where groups were not appearing in environments by correcting the ID used for API calls in the groups list feature.

  • Changed import from projectLogic to teamLogic in /frontend/src/scenes/groups/groupsListLogic.ts
  • Replaced currentProjectId with currentTeamId for API calls to properly handle environment-specific group listings
  • Fix aligns with existing implementation pattern seen in pipeline overview logic

💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@spaceemotion spaceemotion changed the title fix: Use correct ID when listing groups in a project fix: Use correct env. ID when listing groups in a project Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Frontend uses wrong Project ID for looking up groups when using an environment
1 participant