feat: hide recordings viewed by anyone #29092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
97b8567 to
5be19ca
Compare
There was a problem hiding this comment.
PR Summary
This PR enhances the session recording filtering functionality by allowing users to hide recordings that have been viewed by any user, not just the current user, providing more granular control over the recording list visibility.
- Added three-state option in
frontend/src/scenes/session-recordings/player/playerSettingsLogic.tsto support 'current-user', 'any-user', or false forhideViewedRecordings - Implemented new
HideRecordingsMenucomponent infrontend/src/scenes/session-recordings/filters/RecordingsUniversalFilters.tsxreplacing the simple toggle - Modified
sessionRecordingsPlaylistLogic.tsto filter recordings based on bothrec.viewedandrec.viewers.length - Added backward compatibility handling for legacy boolean values in player settings
3 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
frontend/src/scenes/session-recordings/player/playerSettingsLogic.ts
Outdated
Show resolved
Hide resolved
frontend/src/scenes/session-recordings/filters/RecordingsUniversalFilters.tsx
Show resolved
Hide resolved
veryayskiy
reviewed
Feb 22, 2025
| // hideViewRecordings used to be flat boolean | ||
| // if someone has it set to true, we should set it to 'current-user' | ||
| // to upgrade them to the new behavior | ||
| // this can be deleted after a few weeks |
There was a problem hiding this comment.
famous last words before never touching it)))
|
Size Change: +526 B (+0.01%) Total Size: 9.71 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up to #29067
now that we know if other people have watched a recording, we can offer you the option to only see recordings that nobody has watched