Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors on demo #2909

Merged
merged 1 commit into from
Jan 11, 2021
Merged

Fix errors on demo #2909

merged 1 commit into from
Jan 11, 2021

Conversation

mariusandra
Copy link
Collaborator

Changes

  • Fixes few JS errors that broke the demo page (that even resulted in window.posthog being undefined for me...)

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@mariusandra mariusandra requested a review from Twixes January 11, 2021 09:18
@timgl timgl temporarily deployed to posthog-fix-demo-html-7lk3cjne January 11, 2021 09:20 Inactive
Twixes
Twixes approved these changes Jan 11, 2021
View reviewed changes
Copy link
Member

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible

@Twixes Twixes merged commit 8cbc0c6 into master Jan 11, 2021
@Twixes Twixes deleted the fix-demo-html branch January 11, 2021 10:44
@sathishcyberintelsysnew sathishcyberintelsysnew mentioned this pull request Mar 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Twixes Twixes Twixes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mariusandra @Twixes @timgl