fix(LemonSlider): change type of button in LemonSlider "button" instead of "submit"

[havenbarnes]

Problem

I noticed that pressing on the button within Sliders submits a form if the slider is in one. I can't imagine we're relying on this behavior anywhere, and it feels buggy.

Changes

Cause of bug: On most browsers, the default button type is submit. This simply overrides the type to button

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Screenity.video.-.Feb.21.2025.mp4

[greptile-apps]

PR Summary

Fixed an issue where LemonSlider's handle button could trigger unintended form submissions by defaulting to type="submit" in browsers.

• Modified /frontend/src/lib/lemon-ui/LemonSlider/LemonSlider.tsx to explicitly set type="button" on the slider handle button
• Prevents form submission when interacting with sliders placed within forms while maintaining all existing slider functionality

_{1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile}

[github-actions]

Size Change: +14 B (0%)

Total Size: 9.71 MB

ℹ️ View Unchanged

Filename	Size	Change
frontend/dist/toolbar.js	9.71 MB	+14 B (0%)

_{compressed-size-action}

[adamleithp]

Absolutely good call.