-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: playwright 16 #28994
Merged
Merged
chore: playwright 16 #28994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR migrates event-related tests from Cypress to Playwright, reorganizing mock data files into a more structured directory hierarchy and introducing new test coverage.
- Added
playwright/e2e/events.spec.ts
with comprehensive test coverage for events functionality, including property filtering, feature flags, and column management - Moved billing mock files to dedicated
/mocks/billing/
directory for better organization - Added new event-related mock files in
/mocks/events/
including property definitions and session recordings - Potential issue: Duplicate feature flag IDs in
feature_flag_property_definition.json
could cause test reliability problems - Issue:
$browser
property incorrectly marked as numerical inproperty_definitions.json
when it should be a string type
14 file(s) reviewed, 7 comment(s)
Edit PR Review Bot Settings | Greptile
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
caf9120
to
e5dcdbe
Compare
e5dcdbe
to
e2685cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
events