Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: playwright 16 #28994

Merged
merged 15 commits into from
Feb 21, 2025
Merged

chore: playwright 16 #28994

merged 15 commits into from
Feb 21, 2025

Conversation

pauldambra
Copy link
Member

events

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR migrates event-related tests from Cypress to Playwright, reorganizing mock data files into a more structured directory hierarchy and introducing new test coverage.

  • Added playwright/e2e/events.spec.ts with comprehensive test coverage for events functionality, including property filtering, feature flags, and column management
  • Moved billing mock files to dedicated /mocks/billing/ directory for better organization
  • Added new event-related mock files in /mocks/events/ including property definitions and session recordings
  • Potential issue: Duplicate feature flag IDs in feature_flag_property_definition.json could cause test reliability problems
  • Issue: $browser property incorrectly marked as numerical in property_definitions.json when it should be a string type

14 file(s) reviewed, 7 comment(s)
Edit PR Review Bot Settings | Greptile

@pauldambra pauldambra merged commit b713e70 into master Feb 21, 2025
89 checks passed
@pauldambra pauldambra deleted the chore/cyp-2-ply-16 branch February 21, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant