Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop guessing issue first seen #28874

Merged
merged 3 commits into from
Feb 19, 2025
Merged

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented Feb 18, 2025

Problem

We used to use the issue created_at as the first_seen field

Changes

  • Preload fingerprints when serializing issues
  • Use the first_seen field from those (benefit of working across issue merges)

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here: app.greptile.com/review/github.

4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@daibhin daibhin requested a review from a team February 18, 2025 16:11
@daibhin daibhin merged commit 970797c into master Feb 19, 2025
92 checks passed
@daibhin daibhin deleted the dn-fix/stop-guessing-first-seen branch February 19, 2025 13:58
slshults pushed a commit that referenced this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants