Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow more questions options #28765

Merged
merged 3 commits into from
Feb 16, 2025

Conversation

lucasheriques
Copy link
Contributor

@lucasheriques lucasheriques commented Feb 15, 2025

Problem

Closes #27494

Changes

trivial change - main one was just adapting the UI to handle it

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

yes

How did you test this code?

tested with surveys for both multiple question and single choice with 15 options

Copy link
Contributor

github-actions bot commented Feb 15, 2025

Size Change: 0 B

Total Size: 1.21 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.21 MB

compressed-size-action

@lucasheriques lucasheriques marked this pull request as ready for review February 15, 2025 19:39
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here: app.greptile.com/review/github.

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@lucasheriques lucasheriques requested a review from a team February 15, 2025 19:39
@lucasheriques lucasheriques self-assigned this Feb 15, 2025
@lucasheriques lucasheriques enabled auto-merge (squash) February 15, 2025 20:02
@lucasheriques lucasheriques merged commit c4e3f9a into master Feb 16, 2025
104 checks passed
@lucasheriques lucasheriques deleted the chore/allow-more-questions-options branch February 16, 2025 01:25
HamedMP pushed a commit that referenced this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Surveys - Increase the number of allowed choices for single and multiple choices questions
2 participants