chore(no-code experiments): refactor toolbar (1) #28206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Summary
This PR implements the first phase of refactoring the no-code experiments toolbar, focusing on improving content editing and state management.
- Enforces mutually exclusive text/HTML editing in
WebExperimentTransformField.tsxto prevent content override conflicts - Added proper state tracking via
original_html_stateinWebExperimentFormfor undo functionality - Improved state management using Kea reducers instead of direct mutations in
experimentsTabLogic.tsx - Updated type definitions to make variants required and conditions optional in
types.ts - Potential issue:
addNewElementstill initializes both text and html properties which contradicts single-mode editing
4 file(s) reviewed, 5 comment(s)
Edit PR Review Bot Settings | Greptile
frontend/src/toolbar/experiments/WebExperimentTransformField.tsx
Outdated
Show resolved
Hide resolved
|
Size Change: +271 B (+0.02%) Total Size: 1.17 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
danielbachhuber
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
First pass at refactoring Toolbar for no-code experiments. Here's the full list of things to do which I'll be adding to.
Changes
textContentorinnerHTML, but not both, since they can override each other. Currently,innerHTMLupdates last in posthog-js, so it "wins."How did you test this code?
Manually.