chore: posthog and sentry exception capture #27836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
|
Size Change: -5 B (0%) Total Size: 1.16 MB ℹ️ View Unchanged
|
daibhin
commented
Feb 4, 2025
|
|
||
| sentry_capture_exception(error, scope=sentry_scope, **sentry_scope_kwargs) | ||
|
|
||
| if api_key: |
There was a problem hiding this comment.
Really don't like having to use this as the check but tests were failing otherwise. I tried using TEST but didn't seem to work in CI. Try / catch was also possible but seemed like overkill
There was a problem hiding this comment.
Eh, I think we just take it (it's possible we should actually do this inside the call to capture? I'm not sure, no strong feeling)
oliverb123
approved these changes
Feb 5, 2025
|
|
||
| sentry_capture_exception(error, scope=sentry_scope, **sentry_scope_kwargs) | ||
|
|
||
| if api_key: |
There was a problem hiding this comment.
Eh, I think we just take it (it's possible we should actually do this inside the call to capture? I'm not sure, no strong feeling)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Realised we had not yet replaced manual exception capture with a wrapping function that sends data to both Sentry and PostHog
Changes
Replace
capture_exceptionfrom Sentry with an equivalent method in theposthog.exceptionsmodule which also calls PostHog'scapture_exceptionmethodGiven we don't support the concept of scopes & tagging right now I just ignored them. It feels like our issues will have slightly less context as a result but capturing the exceptions is better than what we have right now