perf: Cache the hogql parsing part of setting up the channel type fields #27768
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See #27757
I like this particular approach because if it works, we can generalise it to anywhere we parse static HogQL.
Best viewed while hiding whitespace changes, due to indent changes when adding timings
Changes
Memoize the HogQL parsing part of setting up the channel type fields
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Tests still work despite adding the memoization