feat(web-analytics): Use fbclid to calculate channel type #27686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9fc152e to
889e1a0
Compare
Comment on lines
271
to
276
| has_gclid=ast.CompareOperation( | ||
| op=ast.CompareOperationOp.NotEq, left=aggregate_fields["$entry_gclid"], right=ast.Constant(value=None) | ||
| ), | ||
| has_fbclid=ast.CompareOperation( | ||
| op=ast.CompareOperationOp.NotEq, left=aggregate_fields["$entry_fbclid"], right=ast.Constant(value=None) | ||
| ), |
There was a problem hiding this comment.
Is this the right way to compare against NULL? My understanding is that Clickhouse behaves like Postgres and any comparison against NULL will return NULL. Does HogQL work around this?
There was a problem hiding this comment.
Hmm I can just use the isNull function
There was a problem hiding this comment.
Huh good catch, I am not sure why I thought clickhouse didn't do this
rafaeelaudibert
approved these changes
Jan 20, 2025
zlwaterfield
pushed a commit
that referenced
this pull request
Jan 20, 2025
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See https://posthoghelp.zendesk.com/agent/tickets/23328
Changes
Use
fbclidin the calculation.It's pretty low in the calculation, so it can't override UTM tags and known referrers, but if all else fails, this sets traffic with a
fbclidto either Organic Social or Paid Social. (We can't know just from thefbclidwhether it is paid or not, as meta addsfbclidto all URLs, not just paid).Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Added a test