fix(experiments): only show supported math functions #27589
Conversation
|
Size Change: -766 B (-0.07%) Total Size: 1.16 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
10b1620 to
1c5829b
Compare
I don't get this 🤔 |
|
For experiments that currently do have an unsupported metric type selected, this will somewhat break the UI.
Have we checked how many of such experiments there are? |
Yeah, specifically, I'm was not sure yet what to do with "Weekly active users", but it does make sense to include that one as well, and it should yield correct results. Updated the description. |
Yeah, I have this Metabase question. There is in total ~ 42 metrics that will not be supported for running experiments. I think it's fine to accept that UI glitch for those. |
1fbb4c5 to
41b5248
Compare
| @@ -98,7 +98,15 @@ export function TrendsMetricForm({ isSecondary = false }: { isSecondary?: boolea | |||
| showSeriesIndicator={true} | |||
| entitiesLimit={1} | |||
| showNumericalPropsOnly={true} | |||
| onlyPropertyMathDefinitions={[PropertyMathType.Sum]} | |||
| allowedMathTypes={[ | |||
There was a problem hiding this comment.
Can we define this list in one place and use across both?
This reverts commit 5a4ed21.
f25d672 to
4d41c00
Compare
* master: (103 commits) feat(postgres-estimated-rows): pg Estimated Rows on Data Warehouse Sync (#27634) fix: revert darkmode class toggle, updated content on fills (#27783) chore: upgrade posthog-js (#27790) chore(editor-3001): add back join actions (#27740) feat: Add person distinct ID overrides squash job (as dagster job) (#27710) fix(created-by-sources): Adding `created_by` to sources (#27751) Revert "feat(data-warehouse): V2 pipeline release " (#27791) fix: typo for feature flags (#27786) fix(defer-unmounting): Defer unmounting of react elements (#27742) feat(data-warehouse): V2 pipeline release (#27732) fix(data-warehouse): Ensure dates are actual datetime formats (#27777) fix: enable hot reload for the products dir (#27746) fix: assignee selector when null (#27737) chore: clarify rrweb imports (#27776) chore(deps): Update posthog-js to 1.207.3 (#27779) feat(retention): filters on start/return event (#27770) fix(experiments): only show supported math functions (#27589) feat(web-analytics): Set unique conversions graph when adding conversions goal (#27774) chore: color design system part 1: banner and accents (#27756) chore(experiments): Add tests for funnel attribution options (#27752) ...
Problem
We currently show unsupported math functions. Choosing one of these will yield invalid results.
Changes
Only show supported math functions. That is, functions that return either a
countor asum.How did you test this code?
Tested locally