fix: remove drag button from not-draft surveys

[lucasheriques]

Problem

we currently store questions and surveys as a JSON field, and the question do not have any ids.

this means that, if we change the order of questions in a survey AFTER its live, the order will not be correct.

The ideal solution here is to change the survey.questions model directly, and add an id to each question, instead of relying on the id.

However, as a band-aid fix for now, we're just not allowing users to reorder question after a survey is launched.

Related issue: #27200

Changes

No visible changes, but the draggable icon next to the question is no longer visible for a survey that is launched/ended.

Non-draft survey

Draft survey

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

• Unit tests on the new component
• Verified locally the behavior is what we expect

[github-actions]

Size Change: 0 B

Total Size: 1.13 MB

ℹ️ View Unchanged

Filename	Size
frontend/dist/toolbar.js	1.13 MB

_{compressed-size-action}

[marandaneto]

@lucasheriques can we fix the spacing when the drag icon isn't visible? you can see in screenshot 1 an extra space/padding between questions 1 and 2 in relation to the confirmation message.

[marandaneto]

left a comment otherwise LGTM.
I agree with the quick bandaid solution until we come up with a proper fix.