Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin editor #2743

Merged
merged 32 commits into from
Dec 14, 2020
Merged

Plugin editor #2743

merged 32 commits into from
Dec 14, 2020

Conversation

mariusandra
Copy link
Collaborator

Changes

Edit plugins directly in the interface

image

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@mariusandra mariusandra temporarily deployed to posthog-plugin-editor-bqjttks1 December 11, 2020 15:27 Inactive
@mariusandra mariusandra temporarily deployed to posthog-plugin-editor-bqjttks1 December 11, 2020 16:35 Inactive
@mariusandra mariusandra marked this pull request as ready for review December 11, 2020 16:54
@mariusandra mariusandra requested a review from Twixes December 11, 2020 16:54
@mariusandra mariusandra mentioned this pull request Dec 11, 2020
Closed
@mariusandra mariusandra temporarily deployed to posthog-plugin-editor-bqjttks1 December 11, 2020 23:16 Inactive
@mariusandra mariusandra mentioned this pull request Dec 13, 2020
Closed
Twixes
Twixes reviewed Dec 14, 2020
View reviewed changes
Copy link
Member

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool! Just some notes for more polish.

frontend/src/scenes/plugins/types.ts Outdated Show resolved Hide resolved
frontend/src/scenes/plugins/install/SourcePlugin.tsx Outdated Show resolved Hide resolved
frontend/src/scenes/plugins/install/SourcePlugin.tsx Outdated Show resolved Hide resolved
frontend/src/scenes/plugins/PluginDrawer.tsx Outdated Show resolved Hide resolved
frontend/src/scenes/plugins/SourcePluginTag.tsx Outdated Show resolved Hide resolved
frontend/src/scenes/plugins/PluginSource.tsx Outdated Show resolved Hide resolved
posthog/models/plugin.py Outdated Show resolved Hide resolved
frontend/src/scenes/plugins/PluginCard.tsx Outdated Show resolved Hide resolved
frontend/src/scenes/plugins/PluginDrawer.tsx Outdated Show resolved Hide resolved
frontend/src/scenes/plugins/PluginCard.tsx Outdated Show resolved Hide resolved
@mariusandra mariusandra temporarily deployed to posthog-plugin-editor-bqjttks1 December 14, 2020 12:20 Inactive
@mariusandra mariusandra temporarily deployed to posthog-plugin-editor-bqjttks1 December 14, 2020 14:14 Inactive
@mariusandra mariusandra temporarily deployed to posthog-plugin-editor-bqjttks1 December 14, 2020 14:26 Inactive
@mariusandra mariusandra temporarily deployed to posthog-plugin-editor-bqjttks1 December 14, 2020 14:32 Inactive
@mariusandra mariusandra temporarily deployed to posthog-plugin-editor-bqjttks1 December 14, 2020 14:34 Inactive
@mariusandra
Copy link
Collaborator Author

Some things fixed with a comment, some without, and except for one issue (static heights) everything else should be fixed.

Since the interface might change dramatically between now and the next release, I'd propose to wait a bit with the height issue. Making this properly responsive is a lot of work... and I'd rather spend that time working on higher priority tickets :).

@mariusandra mariusandra requested a review from Twixes December 14, 2020 14:36
Twixes
Twixes approved these changes Dec 14, 2020
View reviewed changes
Copy link
Member

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@Twixes Twixes merged commit f3e4cad into master Dec 14, 2020
@Twixes Twixes deleted the plugin-editor branch December 14, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Twixes Twixes Twixes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariusandra @Twixes