Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use select for numerical properties #2628

Merged
merged 3 commits into from
Dec 2, 2020
Merged

Use select for numerical properties #2628

merged 3 commits into from
Dec 2, 2020

Conversation

timgl
Copy link
Collaborator

@timgl timgl commented Dec 2, 2020

Changes

Before:
image

After
image

Also adds search etc. Had to do quite a few css nastyness to get the select box to look like the menu dropdowns we use everywhere else.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@timgl timgl requested a review from macobo December 2, 2020 12:32
@timgl timgl temporarily deployed to posthog-use-select-for--lte8qm December 2, 2020 12:34 Inactive
macobo
macobo reviewed Dec 2, 2020
View reviewed changes
Copy link
Contributor

@macobo macobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This solves #2619

frontend/src/scenes/insights/ActionFilter/ActionFilterRow.js Outdated Show resolved Hide resolved
frontend/src/scenes/insights/ActionFilter/ActionFilterRow.js Outdated Show resolved Hide resolved
@timgl timgl temporarily deployed to posthog-use-select-for--lte8qm December 2, 2020 13:59 Inactive
@timgl timgl temporarily deployed to posthog-use-select-for--lte8qm December 2, 2020 14:04 Inactive
@timgl
Copy link
Collaborator Author

timgl commented Dec 2, 2020

Resolves #2619

@timgl timgl merged commit 1dd7f73 into master Dec 2, 2020
@timgl timgl deleted the use-select-for-numerical-properties branch December 2, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macobo macobo macobo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timgl @macobo