Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show all items at date when hovering a LineGraph #2600

Merged
merged 1 commit into from
Dec 1, 2020
Merged

Show all items at date when hovering a LineGraph #2600

merged 1 commit into from
Dec 1, 2020

Conversation

macobo
Copy link
Contributor

@macobo macobo commented Dec 1, 2020

Changes

We now show all data points for a date (or 0 if the data is missing on date). Ran across this when doing #2560

Before:
Peek 2020-12-01 15-17

After:
Peek 2020-12-01 15-19

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@macobo
Show all items at date when hovering a LineGraph
a8decc4 
This makes it easier to read graphs with multiple lines.

Fixes #2597
@macobo macobo requested a review from timgl December 1, 2020 13:22
@macobo macobo mentioned this pull request Dec 1, 2020
Closed
@timgl timgl temporarily deployed to posthog-improve-behavio-6gl0ff December 1, 2020 13:24 Inactive
@timgl timgl merged commit 99a2c60 into master Dec 1, 2020
@timgl timgl deleted the improve-behavior-chart-hover branch December 1, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timgl timgl Awaiting requested review from timgl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macobo @timgl