Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show session recording play button if no FullSnapshot rrweb events #2547

Merged
merged 1 commit into from
Nov 27, 2020
Merged

Don't show session recording play button if no FullSnapshot rrweb events #2547

merged 1 commit into from
Nov 27, 2020

Conversation

macobo
Copy link
Contributor

@macobo macobo commented Nov 27, 2020 •
edited
Loading

Changes

Don't show session recording play button if no FullSnapshot rrweb events

This avoids showing fully broken recordings to users. We're working on
reducing the number of errors.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@macobo
Don't show session recording play button if no FullSnapshot rrweb events
7359e33 
This avoids showing fully broken recordings to users. We're working on
reducing the number of errors.
@timgl timgl temporarily deployed to posthog-filter-sessions-en7nhf November 27, 2020 12:23 Inactive
@macobo macobo requested a review from timgl November 27, 2020 12:24
@timgl timgl merged commit 940b3d1 into master Nov 27, 2020
@timgl timgl deleted the filter-sessions-without-full-snapshot branch November 27, 2020 12:36
@macobo macobo mentioned this pull request Nov 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timgl timgl Awaiting requested review from timgl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macobo @timgl