fix: alert calculation counter #25366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twixes
approved these changes
Oct 3, 2024
neilkakkar
reviewed
Oct 3, 2024
| "alerts_checked", | ||
| "Number of alerts we tried to check", | ||
| labelnames=["calculation_interval"], | ||
| ALERT_COMPUTED_COUNTER = Counter( |
There was a problem hiding this comment.
zero context flyby, you can check locally whether these metrics are firing correctly or not, by triggering this function and then going to localhost:8001/_metrics which will show you all fired metrics.
There was a problem hiding this comment.
aah amazing! can see it there now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt #2 to fix the alert counter