chore: Add denylist for elements_chain #19193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…over the weekend, then will switch to denylist only.
bretthoerner
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting ready to flip from allowlist to denylist. Will run with both over the weekend, then will switch to denylist only next week.
Problem
Adding a denylist for the elements_chain behavior to allow for better control
Changes
Team id needs to be present in
ELEMENT_CHAIN_AS_STRING_TEAMSand also NOT present inELEMENT_CHAIN_AS_STRING_EXCLUDED_TEAMS(orELEMENT_CHAIN_AS_STRING_EXCLUDED_TEAMSneeds to not exist) for decide to emitelementsChainAsStringparameter in its JSON responseHow did you test this code?
Updated
test_decide_element_chain_as_stringto test for both allowlist and denylist entries