Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make session recording possible #1821

Merged
merged 8 commits into from
Oct 8, 2020
Merged

Make session recording possible #1821

merged 8 commits into from
Oct 8, 2020

Conversation

macobo
Copy link
Contributor

@macobo macobo commented Oct 8, 2020

Changes

Companion PR to PostHog/posthog-js#88

  • /decide endpoint now returns whether to record this session or not
    • Based on a team toggle, which required some refactoring of the endpoint
  • rrweb.js is served from posthog to enable posthog-js to load it

Note: First PR, please be cruel 😈

Checklist

  • All querysets/queries filter by Team (if this PR affects any querysets/queries)
  • Backend tests (if this PR affects the backend)
  • Cypress E2E tests (if this PR affects the front and/or backend)

macobo added 7 commits October 8, 2020 10:29
This will be loaded by posthog.js and start the recording.
This will be used to figure out by posthog.js whether to capture session
data or not.
…ture flags

This will be used for deciding whether to capture or not session
recordings
Will be used by posthog.js to turn recording on/off
@macobo macobo requested a review from yakkomajuri October 8, 2020 07:32
@timgl timgl temporarily deployed to posthog-snippet-xjvab8vimopefv October 8, 2020 07:33 Inactive
@timgl timgl temporarily deployed to posthog-snippet-88imnmnhhovnri October 8, 2020 07:48 Inactive
@jamesefhawkins
Copy link
Collaborator

NB This will close #149 (woohoo!)

@macobo
Copy link
Contributor Author

macobo commented Oct 8, 2020

@jamesefhawkins Not quite, but great progress - Yakko is doing FE work and we'll need to figure out a capturing story. :) We'll be able to test this out in prod though.

@timgl timgl merged commit d4a00c9 into master Oct 8, 2020
@timgl timgl deleted the snippet branch October 8, 2020 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants